JBP-508: Fund V4/NANA Tests Final Sprint

Synopsis

NANA Buyback Hook, Swap Terminal, and the new REVLoans contracts are in need of tests before we go-to-market.

This was discussed during our recent audit, and jango proposed to put me on task: https://github.com/Enigma-Dark/nana-buyback-hook/issues/7#issuecomment-2204021032

Why me?

I’ve been contributing to the protocol for nearly a year now (v3->v4), and I’ve become seriously acquainted with our codes conventions and intricacies.

I also led the testing efforts of v4- rewriting all of our old javascript units to more modern forge tests. I also refit our existing integration tests while we made extensive changes to the protocol. As well, I supported efforts during our audit period, correcting issues in the protocol contracts & libraries, while adjusting those tests.

Specification

Swap Terminal
Units,
Invariants,
End-to-End

Buyback Hook
End-to-End,
Forked,
Invariants

REVLoans
Units,
Invariants,
Forked

Timeline

3 Weeks.

Risks

Timeline could change if contracts are modified, or if I get kidnapped.

--- nance-actions
- type: Payout
  uuid: 71f7a6c628a34eb1b9ec35c7bc46822f
  payload:
    amount: "11000"
    type: address
    address: "0x73ACD3C8e41524fF083a03067a765030E5385bAd"
  governanceCycles:
    - 82
  pollRequired: false